fix: use buffer number instead of a boolean to limit on_attach calls #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0o
reviewed
Jan 13, 2024
|
Thanks merging for now I looked for easy fix but we see it is more complicated. Next few days I try to propose new solution which should resolve this on tsserver response level. |
pmizio
added a commit
that referenced
this pull request
Jan 14, 2024
…er` (#220) * Revert "fix: use buffer number instead of a boolean to limit on_attach calls (#218)" This reverts commit 54224a2. * Revert "fix: `on_attach` called multiple times with `separate_diagnostic_server` (#213)" This reverts commit df64c37. * fix: `on_attach` called multiple times with `separate_diagnostic_server`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in the comments of PR #213, the use of a boolean prevents
on_attachfrom being called when a new buffer is opened. I tried implementing the same idea of limiting theon_attachcalls but with buffer number instead.