on_attach is being called twice when separate_diagnostic_server is true

[b0o]

Is this intentional? This is causing issues with twoslash-queries, causing duplicate virtual text. Here is my full config:

require('typescript-tools').setup {
  on_attach = function(client, bufnr)
    require('twoslash-queries').attach(client, bufnr)
    require('user.lsp').on_attach(client, bufnr)
  end,
  settings = {
    separate_diagnostic_server = true,
    publish_diagnostic_on = 'insert_leave',
    tsserver_file_preferences = {
      includeCompletionsForModuleExports = true,

      -- inlay hints
      includeInlayParameterNameHints = 'literals',
      includeInlayParameterNameHintsWhenArgumentMatchesName = false,
      includeInlayFunctionParameterTypeHints = true,
      includeInlayVariableTypeHints = true,
      includeInlayVariableTypeHintsWhenTypeMatchesName = false,
      includeInlayPropertyDeclarationTypeHints = true,
      includeInlayFunctionLikeReturnTypeHints = true,
      includeInlayEnumMemberValueHints = true,
    },
    tsserver_format_options = {
      allowIncompleteCompletions = false,
      allowRenameOfImportPath = false,
    },
  },
}

[pmizio]

Probably it isn't. We spawn 2 tsservers in this mode indeed, but still one lsp should be attached. I need to check this.

[pmizio]

@b0o it should be fixed in connected pr, can you check it?

[b0o]

@pmizio Yes, that fixed it. Thank you!

[pmizio]

@b0o merged into master! Thanks for checking it up.

[chaozwn]

Probably it isn't. We spawn 2 tsservers in this mode indeed, but still one lsp should be attached. I need to check this.

I think it might be because they didn't disable the tsserver.

[b0o]

I think it might be because they didn't disable the tsserver

Nope, I only had typescript-tools enabled.

[chaozwn]

I think it might be because they didn't disable the tsserver

Nope, I only had typescript-tools enabled.

The latest fix PR is problematic; you can try using it to open a React project. Then attempt to rename a variable, and open two files consecutively. You will notice that only the first file is affected.

[b0o]

Hmm, I don't have the same issue here. Opening two files and renaming a variable shared between them works as expected.

[b0o]

@chaozwn does #218 fix this for you?

[chaozwn]

@chaozwn does #218 fix this for you?

I'll test it out.

[chaozwn]

@chaozwn does #218 fix this for you?

works well. wait merge.