Adapt for DashBase v1 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these were moved to `DashBase.jl` during the DashBase v1 push
these are now in `DashBase.jl` since DashBase v1. This makes PlotlyBase no longer a `Dash.jl` dep! Requires is also no longer needed in `Dash.jl`
which includes the DashBase "weakdeps" so that we can test plotly graph rendering via the `DashBase` extensions. since the dash test driver uses `julia --project` as base command, we must `cd` into `test/integration` and setup `Dash` as a dev package manually. Update the dev docs accordingly!
New snapshots
|
|
Merging into dev. This will be part of If anyone is willing to test drive |
This was referenced Aug 24, 2023
🤦 I forgot about this. Sorry! I'll make the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires plotly/DashBase.jl#9, supersedes #219 and will resolve #221
Commit fb011f3 is the fun one, where we remove the
DashBase.to_dashdefinitions from this repo. They are now rightfully placed in DashBase proper. This makes Dash no longer depend directly on PlotlyBase and Requires 🎉Commit 70ec860 is less fun, where we need to workaround the fact that we cannot use test deps for the integration tests as the
JuliaRunner(cc plotly/dash#2573) usejulia --projectas its base command to boot up the Dash servers.With commits f003ddf and 421c2f4, we'll test graph rendering (with snapshots!) using all the DashBase extensions from now on.