We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DashBase.to_dash
Dash.jl/src/plotly_base.jl
Lines 1 to 8 in d01ce73
Dash.jl/src/plotly_js.jl
Lines 1 to 7 in d01ce73
are defining DashBase.to_dash methods on type the Dash module does not own. This is type-piracy!
We should move these method definitions to https://github.com/plotly/DashBase.jl inside package extension modules with PlotlyBase.jl and PlotlyJS.jl as weakdeps.
The text was updated successfully, but these errors were encountered:
related: #214
Sorry, something went wrong.
After resolving this issue, we'll be able to drop PlotlyBase as a dep.
PlotlyBase
Moreover, we'll be pretty close to dropping all references to the JSON package, with the exception of
JSON
Dash.jl/gen_resources/generator/github.jl
Line 45 in d01ce73
Dash.jl/test/integration/dash_assets/test_dash_assets.py
Line 27 in d01ce73
Successfully merging a pull request may close this issue.
Dash.jl/src/plotly_base.jl
Lines 1 to 8 in d01ce73
Dash.jl/src/plotly_js.jl
Lines 1 to 7 in d01ce73
are defining
DashBase.to_dash
methods on type the Dash module does not own. This is type-piracy!We should move these method definitions to https://github.com/plotly/DashBase.jl inside package extension modules with PlotlyBase.jl and PlotlyJS.jl as weakdeps.
The text was updated successfully, but these errors were encountered: