Switch to Weakdeps #195
Closed
Switch to Weakdeps #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new feature in Julia 1.9+ that should remove the dependency on Requires.jl. It should offer mild precompilation and load time improvement (contingent upon other dependencies here adopting Weakdeps as well).
|
Since the new Weakdeps behavior forces the packages to resolve, it appears that as of Dash 1.2+, the HTTP 1.0+ constraints breaks PlotlyJS.jl -> Blink.jl. So some work downstream will be required to fix this and merge this PR. |
Merged
etpinard
reviewed
Mar 28, 2023
| import JSON | ||
| import PlotlyJS | ||
|
|
||
| function DashBase.to_dash(p::PlotlyJS.SyncPlot) |
There was a problem hiding this comment.
Strictly speaking, shouldn't this go in DashBase.jl?
|
Closing. Will be done in DashBase.jl Tracked in #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature in Julia 1.9+ that should
remove the dependency on Requires.jl. It should
offer mild precompilation and load time improvement (contingent upon other dependencies here adopting Weakdeps as well).