Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out test helper functionality so XCTest isn't a hard requirement #70

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Aug 25, 2022

Depending on the consumption point, the bitcode disable can cause issues for some users, so i split the test helper out of the test case, so it can be used by the test case, and also by itself

Version

Published prerelease version: 0.1.1-next.15

Changelog

🐛 Bug Fix

📝 Documentation

Authors: 5

@hborawski hborawski added the patch Increment the patch version when merged label Aug 25, 2022
@hborawski hborawski requested a review from adierkens as a code owner August 25, 2022 18:18
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #70 (e52d0fc) into main (ea59026) will decrease coverage by 0.36%.
The diff coverage is 52.85%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   77.32%   76.95%   -0.37%     
==========================================
  Files         130      130              
  Lines        4427     4470      +43     
  Branches     1093     1103      +10     
==========================================
+ Hits         3423     3440      +17     
- Misses        727      754      +27     
+ Partials      277      276       -1     
Impacted Files Coverage Δ
core/player/src/plugins/flow-exp-plugin.ts 93.33% <ø> (-1.41%) ⬇️
core/player/src/validation/controller.ts 84.49% <ø> (ø)
core/view/src/view.ts 65.90% <ø> (ø)
tools/cli/src/commands/dsl/compile.ts 0.00% <0.00%> (ø)
tools/cli/src/utils/babel-register.ts 0.00% <ø> (ø)
language/dsl/src/compiler/compiler.ts 51.66% <28.57%> (-21.87%) ⬇️
core/player/src/player.ts 78.29% <50.00%> (-1.39%) ⬇️
core/view/src/parser/index.ts 79.34% <75.00%> (+1.96%) ⬆️
core/flow/src/flow.ts 100.00% <100.00%> (ø)
core/schema/src/schema.ts 50.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hborawski hborawski merged commit cea35d7 into main Aug 25, 2022
@hborawski hborawski deleted the testutils-no-xctest branch August 25, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant