Add subpath support for published docs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KetanReddy
reviewed
Aug 8, 2022
docs/site/components/Navigation.tsx
Outdated
|
|
||
| const data = await response.json(); | ||
| const versions = data | ||
| .filter((d) => d.type === 'dir' && d.name.match(/^v\d$/)) |
There was a problem hiding this comment.
Shouldn't this regex match any name that is a valid semvar version or are we organizing the docs folders differently?
There was a problem hiding this comment.
The docs are published by major -- so v0, v1, etc
I should fix it to handle vXX though
There was a problem hiding this comment.
The release folder is determined from
Line 57 in 900e3c6
There was a problem hiding this comment.
Yeah, minor/patch versions were going to be my followup question. Also not sure where we landed on publishing docs for release candidates and canaries.
There was a problem hiding this comment.
Anything merged to main (effectively an RC) goes under next -- we don't have anything for PR canaries yet
This was referenced Aug 17, 2022
Merged
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47
Re-organizes how the docs site is merged together. Now creates a
.tar.gzof the full merged site, stamps that result to a new.tar.gz, and uploads that to github-pages.The merged
.tar.gzis stamped twice depending on it's output directory (/latest,/next,/<version>)Version Selection
Adds a menu selection for
latest,nextand any released versionVersion
Published prerelease version:
0.1.1-next.1Changelog
🐛 Bug Fix
📝 Documentation
Authors: 4