Update AnimationComponent to the new component format
#4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellthompson
approved these changes
Apr 5, 2022
yaustar
pushed a commit
that referenced
this pull request
Oct 6, 2022
yaustar
added a commit
that referenced
this pull request
Oct 19, 2022
…ion is playing (#4765) * Processing the animation data properties in the original order before PR #4174 * Return a sensible value for animation component duration if no animation is playing * Return max value instead * Reverting value to 0 with warning * Update src/framework/components/animation/component.js Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Co-authored-by: Steven Yau <syau@snapchat.com> Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
AnimationComponentto the currently recommended format. In other words, it no longer uses theAnimationComponentDataclass (apart from for theenabledproperty).I confirm I have read the contributing guidelines and signed the Contributor License Agreement.