Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation (legacy) component auto plays even when activate is off #4694

Closed
yaustar opened this issue Oct 4, 2022 · 2 comments · Fixed by #4698
Closed

Animation (legacy) component auto plays even when activate is off #4694

yaustar opened this issue Oct 4, 2022 · 2 comments · Fixed by #4698
Assignees
Labels
area: animation Animation related issue bug

Comments

@yaustar
Copy link
Collaborator

yaustar commented Oct 4, 2022

@yaustar yaustar added bug area: animation Animation related issue labels Oct 4, 2022
@yaustar
Copy link
Collaborator Author

yaustar commented Oct 5, 2022

This PR broke the activate check: #4174

@yaustar
Copy link
Collaborator Author

yaustar commented Oct 5, 2022

This is the line that broke this: https://github.com/playcanvas/engine/pull/4174/files#diff-d5724601bc041a9e8d207bd386d5c4ea84f41e4fdc44a34f047c01bfd568da88R52

Because the assets are set first, onSetAnimations is called and where it checks activate (which is true by default) and plays the animation.

It looks like the properties in code before this change was done purposely done in a specific order so that assets property was last

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animation Animation related issue bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants