lightning(dm): add current speed in status #7212
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/cc @D3Hunter |
|
/run-verify |
|
/run-dm-integration-test |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 64a6f20
|
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7212 +/- ##
================================================
+ Coverage 59.6043% 59.7377% +0.1333%
================================================
Files 790 790
Lines 91089 91192 +103
================================================
+ Hits 54293 54476 +183
+ Misses 32051 31976 -75
+ Partials 4745 4740 -5 |
|
/run-all-tests |
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
|
/run-engine-integration-test |
2 similar comments
|
/run-engine-integration-test |
|
/run-engine-integration-test |
| @@ -118,20 +118,23 @@ func (PacketType) EnumDescriptor() ([]byte, []int) { | |||
| } | |||
|
|
|||
| type Packet struct { | |||
| //[default = 17]; | |||
There was a problem hiding this comment.
@lance6716 Why files in proto/canal are changed?
There was a problem hiding this comment.
I just run make entry. Maybe format tool hook is also invoked.
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: ref #7115
What is changed and how it works?
the speed has unit of "bytes per seconds", and will display the old value if "finished bytes" is not updated.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note