dumpling: add recent speed to dump status #38456
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Co-authored-by: D3Hunter <jujj603@gmail.com>
|
/run-all-tests |
dumpling/export/dump.go
Outdated
| @@ -55,6 +55,8 @@ type Dumper struct { | |||
| selectTiDBTableRegionFunc func(tctx *tcontext.Context, conn *BaseConn, meta TableMeta) (pkFields []string, pkVals [][]string, err error) | |||
| totalTables int64 | |||
| charsetAndDefaultCollationMap map[string]string | |||
|
|
|||
| statusRecorder *StatusRecorder | |||
There was a problem hiding this comment.
Sorry now I want to change the name to SpeedRecorder or something
| elapsed = 1 | ||
| } | ||
| currentSpeed := (finished - s.lastFinished) / elapsed | ||
| if currentSpeed == 0 { |
There was a problem hiding this comment.
Can we use float variable?
There was a problem hiding this comment.
the unit of measurement should be Byte/s, so no need to use float.
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b047955
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #38455
Problem Summary:
similar pr: pingcap/tiflow#7212, tiflow will import tidb's SpeedRecorder after this pr merged.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.