-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix the issue that one task losing heartbeat will block other tasks (#57919) #59392
ttl: fix the issue that one task losing heartbeat will block other tasks (#57919) #59392
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This PR depends on #59392 to test. |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
04e82f5
to
56de059
Compare
…57919-to-release-7.5 Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
56de059
to
ebcd25e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #59392 +/- ##
================================================
Coverage ? 72.1686%
================================================
Files ? 1417
Lines ? 413558
Branches ? 0
================================================
Hits ? 298459
Misses ? 95088
Partials ? 20011
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
This is an automated cherry-pick of #57919
What problem does this PR solve?
Issue Number: close #57915
Problem Summary:
If one task failed to update heartbeat, the other tasks will not be tried. It's not expected.
What changed and how does it work?
Print an error and continue to try other tasks.
This PR also adapts the same change for job.
Check List
Tests
Release note