Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: fix the issue that one task losing heartbeat will block other tasks #57919

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 3, 2024

What problem does this PR solve?

Issue Number: close #57915

Problem Summary:

If one task failed to update heartbeat, the other tasks will not be tried. It's not expected.

What changed and how does it work?

Print an error and continue to try other tasks.

This PR also adapts the same change for job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@YangKeao YangKeao changed the title fix the issue that one task losing heartbeat will block other tasks ttl: fix the issue that one task losing heartbeat will block other tasks Dec 3, 2024
@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2024

/check-issue-triage-complete

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.8984%. Comparing base (ec5b26e) to head (1916dcb).
Report is 412 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57919        +/-   ##
================================================
+ Coverage   73.1711%   73.8984%   +0.7273%     
================================================
  Files          1671       1673         +2     
  Lines        460675     463835      +3160     
================================================
+ Hits         337081     342767      +5686     
+ Misses       102850     100448      -2402     
+ Partials      20744      20620       -124     
Flag Coverage Δ
integration 43.5375% <7.8431%> (?)
unit 72.6821% <76.4705%> (+0.3787%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.0779% <ø> (+3.3106%) ⬆️
parser ∅ <ø> (∅)
br 45.5094% <ø> (-0.4979%) ⬇️

@YangKeao YangKeao requested a review from zimulala December 3, 2024 09:22
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
Copy link

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 08:26:02.127006824 +0000 UTC m=+1143349.746661402: ☑️ agreed by lcwangchao.
  • 2024-12-04 08:58:13.697220013 +0000 UTC m=+1231681.316874526: ☑️ agreed by zimulala.

Copy link

ti-chi-bot bot commented Dec 4, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 1916dcb link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 0392cdd into pingcap:master Dec 4, 2024
23 of 24 checks passed
@YangKeao YangKeao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58710.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@YangKeao YangKeao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Feb 11, 2025
@YangKeao YangKeao added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Feb 11, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #59390.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 11, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #59391.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 11, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #59392.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 11, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One TTL task losing heartbeat will block other tasks from getting heartbeat
4 participants