-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix join resolveIndex won't find its column from children schema and amend join's lused and rused logic for reversed column ref from join schema to its children #51258
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 after resolve the conflict.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, fixdb, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #51203
What problem does this PR solve?
Issue Number: close #42588
Problem Summary:
What changed and how does it work?
issue #42588 is caused by many factors and this pr is try to resolve them all.
lused
andrused
are order unawareness, which means even if we allow reversed column ref in join schema itself to its children, it will break its assumption here too. So we need to fix here as well.example:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.