Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support alter table row_format for the compatibility #48769

Merged
merged 2 commits into from
Nov 22, 2023
Merged

*: support alter table row_format for the compatibility #48769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd944ee
*: support alter table row_format for the compatibility
hawkingrei Nov 22, 2023
3e340ed
update
hawkingrei Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ddl/ddl_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3794,6 +3794,7 @@ func (d *ddl) AlterTable(ctx context.Context, sctx sessionctx.Context, stmt *ast
Name: model.NewCIStr(opt.StrValue),
}
case ast.TableOptionEngine:
case ast.TableOptionRowFormat:
case ast.TableOptionTTL, ast.TableOptionTTLEnable, ast.TableOptionTTLJobInterval:
var ttlInfo *model.TTLInfo
var ttlEnable *bool
Expand Down
2 changes: 1 addition & 1 deletion tests/integrationtest/r/util/admin.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ALTER TABLE t1 ADD COLUMN cc1 CHAR(36) NULL DEFAULT '';
ALTER TABLE t1 ADD COLUMN cc2 VARCHAR(36) NULL DEFAULT '';
ALTER TABLE t1 ADD INDEX idx1 (cc1);
ALTER TABLE t1 ADD INDEX idx2 (cc2);
ALTER TABLE t1 engine=innodb;
ALTER TABLE t1 engine=innodb, ROW_FORMAT=DYNAMIC;
admin check table t1;
drop table if exists t1;
create table t1 (
Expand Down
2 changes: 1 addition & 1 deletion tests/integrationtest/t/util/admin.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ALTER TABLE t1 ADD COLUMN cc1 CHAR(36) NULL DEFAULT '';
ALTER TABLE t1 ADD COLUMN cc2 VARCHAR(36) NULL DEFAULT '';
ALTER TABLE t1 ADD INDEX idx1 (cc1);
ALTER TABLE t1 ADD INDEX idx2 (cc2);
ALTER TABLE t1 engine=innodb;
ALTER TABLE t1 engine=innodb, ROW_FORMAT=DYNAMIC;
admin check table t1;
drop table if exists t1;
create table t1 (
Expand Down