-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support alter table row_format for the compatibility #48769
*: support alter table row_format for the compatibility #48769
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a unit test to avoid future break?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48769 +/- ##
================================================
+ Coverage 71.0831% 72.6684% +1.5852%
================================================
Files 1365 1389 +24
Lines 404549 411209 +6660
================================================
+ Hits 287566 298819 +11253
+ Misses 97019 93498 -3521
+ Partials 19964 18892 -1072
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #48754
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.