Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server,session: Add status vars for compression #48152

Merged
merged 11 commits into from
Nov 16, 2023
Merged

server,session: Add status vars for compression #48152

merged 11 commits into from
Nov 16, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 31, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44473

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The `Compression`, `Compression_algorithm` and `Compression_level` status variables were added.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-tests-checked size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2023
@tiprow tiprow
Copy link

tiprow bot commented Oct 31, 2023

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

This is how this now looks:

$ mysqlsh --compression-algorithms=zlib --sql mysql://root@127.0.0.1:4000/test

sql> SHOW SESSION STATUS LIKE 'Compression%';
+-----------------------+-------+
| Variable_name         | Value |
+-----------------------+-------+
| Compression           | ON    |
| Compression_algorithm | zlib  |
| Compression_level     | 6     |
+-----------------------+-------+
3 rows in set (0.0080 sec)

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 31, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

The MySQL Client show this, both with and without this PR:

mysql> \s
...
Protocol:		Compressed, algorithms: zlib, zstd level: 3
...

And MySQL Shell with this PR:

sql> \s
...
Compression:                  Enabled (zstd)
...

And MySQL Shell without this PR:

sql> \s
...
Compression:                  Enabled
...

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #48152 (6081df6) into master (6144ddd) will increase coverage by 1.4308%.
Report is 9 commits behind head on master.
The diff coverage is 62.7907%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48152        +/-   ##
================================================
+ Coverage   71.2751%   72.7060%   +1.4308%     
================================================
  Files          1358       1384        +26     
  Lines        403571     410542      +6971     
================================================
+ Hits         287646     298489     +10843     
+ Misses        96029      93187      -2842     
+ Partials      19896      18866      -1030
Flag Coverage Δ
integration 43.3832% <20.9302%> (?)
unit 71.2446% <62.7907%> (-0.0305%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8359% <ø> (-4.2322%) ⬇️

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/test all

@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2023

/retest

@dveeden dveeden marked this pull request as ready for review November 1, 2023 07:04
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

/retest

@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

/cc @yudongusa @easonn7

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

@dveeden: GitHub didn't allow me to request PR reviews from the following users: yudongusa, easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @easonn7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lance6716
lance6716 reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 10:05:17.03401046 +0000 UTC m=+4329914.621120604: ☑️ agreed by djshow832.
  • 2023-11-16 13:56:21.555657469 +0000 UTC m=+4343779.142767616: ☑️ agreed by lance6716.

@dveeden dveeden mentioned this pull request Nov 16, 2023
Merged
12 tasks
yudongusa
yudongusa approved these changes Nov 16, 2023
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, lance6716, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 16, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

/retest

2 similar comments
@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

/retest

@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1f7c1e0 into pingcap:master Nov 16, 2023
@qw4990 qw4990 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@djshow832 djshow832 djshow832 approved these changes

@yudongusa yudongusa yudongusa approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SHOW SESSION STATUS LIKE "Compression";
4 participants
@dveeden @lance6716 @djshow832 @yudongusa