-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SHOW STATUS docs #15363
Update SHOW STATUS docs #15363
Conversation
|
Thanks. Note that if you want you can checkout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments mainly about the scope of variables.
@yahonda Could you check again? |
Looks good to me. |
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
[LGTM Timeline notifier]Timeline:
|
@dveeden Is this PR mergeable? |
@ran-huang Yes |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ran-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hi @dveeden, would you please help confirm if this PR also applies to release-7.5? |
/assign |
What is changed, added or deleted? (Required)
Update the docs for
SHOW STATUS
This is mostly for pingcap/tidb#48152 but it looks like we never properly documented the existing status variables.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
pingcap/tidb#48152