Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SHOW STATUS docs #15363

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Update SHOW STATUS docs #15363

merged 7 commits into from
Dec 4, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 16, 2023

What is changed, added or deleted? (Required)

Update the docs for SHOW STATUS

This is mostly for pingcap/tidb#48152 but it looks like we never properly documented the existing status variables.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

pingcap/tidb#48152

@dveeden dveeden requested a review from mjonss November 16, 2023 16:23
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2023
@dveeden dveeden requested review from ran-huang and qiancai November 16, 2023 16:23
@dveeden
Copy link
Contributor Author

dveeden commented Nov 16, 2023

@dveeden dveeden requested a review from yahonda November 16, 2023 16:37
@yahonda
Copy link
Member

yahonda commented Nov 17, 2023

tiup playground nightly has not include the bee28760d859ded136806927571a1594b6234c59 yet. Let me review this pull request coming Monday.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 17, 2023

tiup playground nightly has not include the bee28760d859ded136806927571a1594b6234c59 yet. Let me review this pull request coming Monday.

Thanks.

Note that if you want you can checkout pingcap/tidb from git and switch to the master branch and run make server && ./bin/tidb-server. This gives you a running TiDB server with the unistore (instead of TiKV) that you can connect to on port 4000. If something hasn't been merged you can use gh pr checkout 1234 to checkout a specific PR. The gh command is the GitHub commandline

Copy link
Member

@yahonda yahonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments mainly about the scope of variables.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 21, 2023

@yahonda Could you check again?

@yahonda
Copy link
Member

yahonda commented Nov 22, 2023

Looks good to me.

@ran-huang ran-huang added the translation/doing This PR's assignee is translating this PR. label Nov 22, 2023
@ran-huang ran-huang self-assigned this Nov 22, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 22, 2023
dveeden and others added 3 commits November 22, 2023 09:11
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 02:42:58.093827328 +0000 UTC m=+545006.759053523: ☑️ agreed by ran-huang.

@ran-huang
Copy link
Contributor

@dveeden Is this PR mergeable?

@dveeden
Copy link
Contributor Author

dveeden commented Nov 30, 2023

@dveeden Is this PR mergeable?

@ran-huang Yes

@ran-huang
Copy link
Contributor

/approve

@ran-huang ran-huang added the lgtm label Dec 4, 2023
Copy link

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit cd152a9 into pingcap:master Dec 4, 2023
@qiancai
Copy link
Collaborator

qiancai commented Dec 29, 2023

hi @dveeden, would you please help confirm if this PR also applies to release-7.5?

@dveeden
Copy link
Contributor Author

dveeden commented Dec 29, 2023

hi @dveeden, would you please help confirm if this PR also applies to release-7.5?

@qiancai This needs modifications when applied to release-7.5. I'll create a PR for that.

dveeden added a commit to dveeden/docs that referenced this pull request Dec 29, 2023
@dveeden dveeden mentioned this pull request Dec 29, 2023
17 tasks
@ran-huang ran-huang added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. and removed translation/doing This PR's assignee is translating this PR. labels Jan 9, 2024
@ran-huang ran-huang removed their assignment Jan 9, 2024
@enkilee
Copy link
Contributor

enkilee commented Jan 11, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.
Development

Successfully merging this pull request may close these issues.

5 participants