Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support check constraint in tidb | tidb-test=pr/2146 #44104

Merged
merged 18 commits into from
Jun 7, 2023
Merged

*: support check constraint in tidb | tidb-test=pr/2146 #44104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
302bb38
commit
fzzf678 May 23, 2023
ae21c86
commit
fzzf678 May 23, 2023
6e05774
commit
fzzf678 May 23, 2023
40c2d35
bazel&errdoc
fzzf678 May 23, 2023
d4d6a6e
add head
fzzf678 May 23, 2023
3d88bb6
Update tables.go
fzzf678 May 23, 2023
aa27cd8
head
fzzf678 May 23, 2023
ff45118
Update integration_test.go
fzzf678 May 23, 2023
a07bf50
refactor
fzzf678 May 24, 2023
9929450
rename
fzzf678 May 24, 2023
ebcc64c
Update ddl_api.go
fzzf678 Jun 1, 2023
915b7f3
Update ddl/constraint.go
fzzf678 Jun 1, 2023
befe763
update head
fzzf678 Jun 1, 2023
984b12c
Update constraint_test.go
fzzf678 Jun 1, 2023
8f0491a
Update constraint_test.go
fzzf678 Jun 1, 2023
3d39c83
Merge remote-tracking branch 'upstream/master' into commit_check_cons…
fzzf678 Jun 1, 2023
5af90d6
Update constraint_test.go
fzzf678 Jun 1, 2023
b34b9eb
Update constraint.go
fzzf678 Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ddl/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ go_library(
"cluster.go",
"column.go",
"constant.go",
"constraint.go",
"ddl.go",
"ddl_algorithm.go",
"ddl_api.go",
Expand Down Expand Up @@ -168,6 +169,7 @@ go_test(
"column_modify_test.go",
"column_test.go",
"column_type_change_test.go",
"constraint_test.go",
"db_cache_test.go",
"db_change_failpoints_test.go",
"db_change_test.go",
Expand Down
11 changes: 0 additions & 11 deletions ddl/column_modify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,17 +705,6 @@ func TestTransactionWithWriteOnlyColumn(t *testing.T) {
tk.MustQuery("select a from t1").Check(testkit.Rows("2"))
}

func TestColumnCheck(t *testing.T) {
store := testkit.CreateMockStoreWithSchemaLease(t, columnModifyLease)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("drop table if exists column_check")
tk.MustExec("create table column_check (pk int primary key, a int check (a > 1))")
defer tk.MustExec("drop table if exists column_check")
require.Equal(t, uint16(1), tk.Session().GetSessionVars().StmtCtx.WarningCount())
tk.MustQuery("show warnings").Check(testkit.RowsWithSep("|", "Warning|8231|CONSTRAINT CHECK is not supported"))
}

func TestModifyGeneratedColumn(t *testing.T) {
store := testkit.CreateMockStoreWithSchemaLease(t, columnModifyLease)
tk := testkit.NewTestKit(t, store)
Expand Down
Loading