Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support check constraint in tidb | tidb-test=pr/2146 #44104

Merged
merged 18 commits into from
Jun 7, 2023
Merged

*: support check constraint in tidb | tidb-test=pr/2146 #44104

merged 18 commits into from
Jun 7, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented May 23, 2023

What problem does this PR solve?

Issue Number: ref #41711

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TonsnakeLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented May 23, 2023

/test all

@fzzf678
Copy link
Contributor Author

fzzf678 commented May 23, 2023

/test all

@fzzf678
Copy link
Contributor Author

fzzf678 commented May 23, 2023

/test all

@fzzf678
Copy link
Contributor Author

fzzf678 commented May 23, 2023

/test all

@fzzf678 fzzf678 marked this pull request as ready for review May 24, 2023 03:35
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented May 24, 2023

/test unit-test

CbcWestwolf
CbcWestwolf reviewed May 28, 2023
View reviewed changes
ddl/constraint_test.go Outdated
@@ -0,0 +1,912 @@
// Copyright 2023 PingCAP, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DITTO

table/constraint.go Outdated
@@ -0,0 +1,255 @@
// Copyright 2023 PingCAP, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DITTO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head updated, PTAL again

@fzzf678 fzzf678 changed the title *: support check constraint in tidb *: support check constraint in tidb | tidb-test=pr/2146 Jun 1, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Jun 1, 2023

/test mysql-test

@TonsnakeLin
Copy link
Contributor

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 7, 2023
@CbcWestwolf
Copy link
Member

/merge

@CbcWestwolf
Copy link
Member

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 7, 2023
@fzzf678 fzzf678 requested a review from TonsnakeLin June 7, 2023 08:10
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-07 08:05:43.641040557 +0000 UTC m=+78235.485675157: ☑️ agreed by CbcWestwolf.
  • 2023-06-07 08:10:54.244715352 +0000 UTC m=+78546.089349940: ☑️ agreed by TonsnakeLin.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Jun 7, 2023

/merge

TonsnakeLin
TonsnakeLin approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TonsnakeLin TonsnakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, TonsnakeLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 8b67cea into pingcap:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzzf678 @TonsnakeLin @CbcWestwolf