Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add <Code>RequestTimeout</Code> to list of retryable errors #41759

Merged
merged 1 commit into from
Mar 15, 2023
Merged

br: add <Code>RequestTimeout</Code> to list of retryable errors #41759

merged 1 commit into from
Mar 15, 2023

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Feb 27, 2023

What problem does this PR solve?

Issue Number: close #41756

Problem Summary:

Some S3-compatible external storage does not return an error response with a human-readable <Message> tag. BR relied on its content and thus failed to recognize a RequestTimeout error is in fact retryable.

What is changed and how it works?

Added the error code into the list of phrases to check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

BR can now properly retry on RequestTimeout transient errors when backing up to Baidu Object Storage (BOS).

@kennytm
br: add <Code>RequestTimeout</Code> to list of retryable errors
8253e21 
fixes pingcap#41756

Signed-off-by: kennytm <kennytm@gmail.com>
@kennytm kennytm added type/bugfix This PR fixes a bug. component/br This issue is related to BR of TiDB. labels Feb 27, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fengou1
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2023
@kennytm
Copy link
Contributor Author

kennytm commented Feb 27, 2023

Note that the customer facing this issue is still on release-5.1. Is it ok to cherry-pick this + #34930 altogether to v5.1.6?

fengou1
fengou1 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@fengou1 fengou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 27, 2023
@ti-chi-bot
Copy link
Member

@tonyxuqqi: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

joccau
joccau approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2023
@joccau
Copy link
Member

joccau commented Mar 15, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8253e21

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Mar 15, 2023
@joccau
Copy link
Member

joccau commented Mar 15, 2023

/run-integration-br-test

@joccau
Copy link
Member

joccau commented Mar 15, 2023

/test unit-test

@ti-chi-bot ti-chi-bot merged commit 7b5c65f into pingcap:master Mar 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #42247.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #42248.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #42249.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42251.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #42252.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42253.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #42254.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
@kennytm @ti-chi-bot
This is an automated cherry-pick of pingcap#41759
10e9b14 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42255.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
@kennytm @ti-chi-bot
This is an automated cherry-pick of pingcap#41759
1b2f63c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@joccau joccau mentioned this pull request Mar 15, 2023
Merged
@kennytm kennytm deleted the fix-41756 branch March 15, 2023 08:44
ti-chi-bot added a commit that referenced this pull request Mar 30, 2023
@ti-chi-bot
br: add <Code>RequestTimeout</Code> to list of retryable errors (#41759…
c1f3c4b 
…) (#42255)

close #41756
ti-chi-bot added a commit that referenced this pull request Apr 12, 2023
@ti-chi-bot
br: add <Code>RequestTimeout</Code> to list of retryable errors (#41759…
b5701ee 
…) (#42251)

close #41756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@joccau joccau joccau approved these changes

@fengou1 fengou1 fengou1 approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BR Backup does not retry on RequestTimeout when the response has no <Message>
5 participants
@kennytm @ti-chi-bot @joccau @tonyxuqqi @fengou1