Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add error into retry list when backup #34930

Merged
merged 9 commits into from
May 26, 2022
Merged

br: add error into retry list when backup #34930

merged 9 commits into from
May 26, 2022

Conversation

joccau
Copy link
Member

@joccau joccau commented May 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #34865

Problem Summary:

What is changed and how it works?

br need to retry backup region when br received the specific error from TiKV when TiKV write sst-file to storage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joccau added 2 commits May 24, 2022 22:27
@joccau
add retry errno
bb45751 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
add retry error
5b94f9b 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2022
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/cc @YuJuncen @fengou1 @3pointer @WangLe1321 PTAL

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @YuJuncen @fengou1 @3pointer @WangLe1321 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from WangLe1321 May 25, 2022 02:15
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/run-integration-br-test

@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2e4b5b16d20b4ca1c404a0a8dfcffac2e89d00c7

@joccau joccau force-pushed the fix-storage-retry branch from 34e4c84 to 07c8718 Compare May 25, 2022 03:16
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/run-integration-br-test

@fengou1
Copy link
Contributor

fengou1 commented May 25, 2022

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@joccau joccau force-pushed the fix-storage-retry branch from 07c8718 to 444d4c5 Compare May 25, 2022 03:40
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/run-integration-br-test

@joccau
maintain test case
c69dbdb 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau joccau force-pushed the fix-storage-retry branch from 444d4c5 to c69dbdb Compare May 25, 2022 04:01
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/run-integration-br-test

@joccau joccau added affects-5.4 This bug affects the 5.4.x(LTS) versions. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels May 25, 2022
3pointer
3pointer reviewed May 25, 2022
View reviewed changes
br/pkg/utils/retry.go
@@ -24,6 +24,7 @@ var retryableServerError = []string{
"error during dispatch",
"put object timeout",
"internalerror",
"not read from or written to within the timeout period",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should add some retry even we meet the error not in the list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For safety, add this error into list currenty, I suggest.
But we add the logic(wait and retry the operation(backup and retry)) into master branch until the work is stable and safe.

3pointer
3pointer approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4a58be6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@3pointer
Copy link
Contributor

/run-mysql-test

@joccau
Copy link
Member Author

joccau commented May 26, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 0f85650 into pingcap:master May 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 26, 2022
@joccau @ti-srebot
cherry pick pingcap#34930 to release-5.4
08a3893 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 26, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34983

ti-chi-bot pushed a commit that referenced this pull request May 31, 2022
@ti-srebot
br: add error into retry list when backup (#34930) (#34983)
4d888ce 
close #34865
@kennytm kennytm mentioned this pull request Feb 27, 2023
Merged
12 tasks
@joccau joccau mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@fengou1 fengou1 fengou1 approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

@WangLe1321 WangLe1321 Awaiting requested review from WangLe1321

Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: backup failed because of backup save file failed
6 participants
@joccau @ti-chi-bot @sre-bot @fengou1 @3pointer @ti-srebot