Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down json_valid to tikv #38290

Merged
merged 7 commits into from
Nov 17, 2022
Merged

expression: push down json_valid to tikv #38290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5944c9a
push down json_valid to tikv
lizhenhuan Oct 3, 2022
b8cf81b
add test
lizhenhuan Oct 3, 2022
9246d32
Merge branch 'master' into push_down_json_valid
lizhenhuan Nov 16, 2022
54e8f7e
Update integration_test.go
lizhenhuan Nov 16, 2022
2a588be
delete line
lizhenhuan Nov 16, 2022
0a5ce1e
fix code
lizhenhuan Nov 17, 2022
dd6c8c9
Merge branch 'master' into push_down_json_valid
xhebox Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions expression/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,8 +1071,7 @@ func scalarExprSupportedByTiKV(sf *ScalarFunction) bool {
// json functions.
ast.JSONType, ast.JSONExtract, ast.JSONObject, ast.JSONArray, ast.JSONMerge, ast.JSONSet,
ast.JSONInsert /*ast.JSONReplace,*/, ast.JSONRemove, ast.JSONLength,
// FIXME: JSONUnquote is incompatible with Coprocessor
ast.JSONUnquote, ast.JSONContains,
ast.JSONUnquote, ast.JSONContains, ast.JSONValid,

// date functions.
ast.Date, ast.Week /* ast.YearWeek, ast.ToSeconds */, ast.DateDiff,
Expand Down
4 changes: 4 additions & 0 deletions planner/core/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3375,6 +3375,10 @@ func TestScalarFunctionPushDown(t *testing.T) {
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where ascii(e);").
CheckAt([]int{0, 3, 6}, rows)

rows[1][2] = "eq(json_valid(test.t.c), 1)"
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where json_valid(c)=1;").
CheckAt([]int{0, 3, 6}, rows)

rows[1][2] = "json_contains(cast(test.t.c, json BINARY), cast(\"1\", json BINARY))"
tk.MustQuery("explain analyze select /*+read_from_storage(tikv[t])*/ * from t where json_contains(c, '1');").
CheckAt([]int{0, 3, 6}, rows)
Expand Down