-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: push down json_valid to tikv #38290
Conversation
Signed-off-by: lizhenhuan <1916038084@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Thanks for the contribution! @xiongjiwei @YangKeao Do you think it's a good time to push this func to TiKV? |
As a reference for other reviewer, the corresponding PR on TiKV: tikv/tikv#13572 has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: lizhenhuan <1916038084@qq.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0a5ce1e
|
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
Signed-off-by: lizhenhuan 1916038084@qq.com
What problem does this PR solve?
Issue Number: close #38289
Problem Summary:
Implement json_valid function push down to tikv
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.