Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Always generate global stats for partitioned tables #37830

Closed
wants to merge 18 commits into from
Closed

*: Always generate global stats for partitioned tables #37830

wants to merge 18 commits into from

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 14, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Always generate global statistics for partitioned tables.

Reverts the PR that falls back on static prune mode if global statistics does not exist.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Always generate global/table level statistics for partitioned tables, regardless of the tidb_partition_prune_mode setting.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 14, 2022
@mjonss mjonss changed the title Always glob stats *: Always generate global stats for partitioned tables Sep 14, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Sep 16, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@mjonss
Copy link
Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

@mjonss
Copy link
Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

@mjonss
Copy link
Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

@mjonss
Copy link
Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Sep 19, 2022

/run-mysql-test tidb-test=pr/1975

@mjonss
Copy link
Contributor Author

mjonss commented Sep 21, 2022

/run-check_dev_2

@mjonss mjonss mentioned this pull request Sep 21, 2022
Merged
4 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Sep 28, 2022

/run-mysql-test tidb-test=pr/1975

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022
@ti-chi-bot
Copy link
Member

@mjonss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2024

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 2109f69 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 2109f69 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 2109f69 link true /test check-dev
idc-jenkins-ci-tidb/build 2109f69 link true /test build
idc-jenkins-ci-tidb/unit-test 2109f69 link true /test unit-test
pull-mysql-client-test 2109f69 link true /test pull-mysql-client-test
pull-integration-ddl-test 2109f69 link true /test pull-integration-ddl-test
pull-br-integration-test 2109f69 link true /test pull-br-integration-test
pull-lightning-integration-test 2109f69 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Defined2014
Copy link
Contributor

Already has tidb_skip_missing_partition_stats session variable, so close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjonss @ti-chi-bot @hawkingrei @Defined2014