Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fallback to static plan for partition table if having no global stats in dynamic prune mode #37573

Merged
merged 25 commits into from
Sep 8, 2022
Merged

planner: fallback to static plan for partition table if having no global stats in dynamic prune mode #37573

merged 25 commits into from
Sep 8, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Sep 2, 2022

What problem does this PR solve?

Issue Number: ref #37535

Problem Summary:

Currently we recommended users to analyze global stats for partition table before enabling dynamic prune mode. If we enabled dynamic prune mode without generating global stats, optimizer will think table stats as pesudo which generates bad plan.

What is changed and how it works?

A proper way is to fallback to static plan if having no global stats in query.

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer Yisaer requested a review from a team as a code owner September 2, 2022 07:46
@Yisaer
remove conflict code
a67066a 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 7, 2022
@Yisaer
fix explain test
877e143 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
@Yisaer
Merge branch 'master' into revise_37537_1
389d277
@Yisaer
fix explain test
616d97a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix test
98bb4dc 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix test
c99442a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08e8c7b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@Yisaer
fix plan
d29d795 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@Yisaer
fix plan
2c4f5b0 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c4f5b0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 7, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1962

@ti-chi-bot ti-chi-bot merged commit 7eb7ca9 into pingcap:master Sep 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 3, success 14, total 17 15 min New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 12 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 13 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 7 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao mentioned this pull request Sep 8, 2022
Closed
@mjonss mjonss mentioned this pull request Sep 8, 2022
Closed
mjonss added a commit to mjonss/tidb that referenced this pull request Sep 14, 2022
@mjonss
Revert "planner: fallback to static plan for partition table if havin…
0bcbad9 
…g no global stats in dynamic prune mode (pingcap#37573)"

This reverts commit 7eb7ca9.

But keeps the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@chrysan chrysan Awaiting requested review from chrysan

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yisaer @ti-chi-bot @sre-bot @qw4990 @Reminiscent @xuyifangreeneyes