-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/kvcache: enhance kvcache (#24242) #25299
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@ClSlaid please accept the invitation then you can push to the cherry-pick pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@breeswish PTAL |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
cherry-pick #24242 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25299
After apply modifications, you can push your change to this PR via:
Related Issues
enhance statement summary #24086
Record all evicted statements information by sum #24083
This PR enables us getting evicted data from kvcache.
What is changed and how it works?
I changed files in util/kvcache, now you can get evicted key-value pairs from LRU cache by adding a optional function parameter on every Put() method.
By using GoLang's variadic parameter, former usage of function remains working fine.
Related changes
Check List
Tests
Side effects
Release note