-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inforschema, executor, util/kvcache, util/statement_summary : Add STATEMENTS_SUMMARY_EVICTED into information_schema (#24513) #25295
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@ClSlaid please accept the invitation then you can push to the cherry-pick pull requests. |
@breeswish PTAL |
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@breeswish PTAL. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@breeswish PTAL |
/run-all-tests |
/run-unit-test |
Please perform a benchmark and post results here. The rest LGTM. |
Bench Marks
Git Hash:
Bench Environment
How did the bench madeGenerate DataGenerate Data with sysbench --config-file=config oltp_point_select --tables=32 --table-size=1000000 prepare set thread used for
Run Point Select bench by executing: sysbench --config-file=config oltp_point_select --tables=32 --table-size=1000000 run Run Read-Only bench (a benchmark containing multiple kinds of database query) by executing: sysbench --config-file=config oltp_read_only --tables=32 --table-size=1000000 run |
/cc @djshow832 |
Won't be cherry-picked to 5.0. |
cherry-pick #24513 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25295
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23920
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
ssMap
'sother
list.Related changes
Check List
Tests
Side effects
Release note