executor: Hide offline pumps/drainers #12862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users find it confusing that offline pumps/drainers still appear when they check the status.
Codecov Report
@@ Coverage Diff @@
## master #12862 +/- ##
=========================================
Coverage 80.059% 80.059%
=========================================
Files 465 465
Lines 107372 107372
=========================================
Hits 85961 85961
Misses 14934 14934
Partials 6477 6477 |
|
LGTM |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Users find it confusing that offline pumps/drainers still appear when
they check the status.
What is changed and how it works?
Don't show offline pumps/drainers.
With pingcap/tidb-binlog#774 merged, binlogctl also hides offline pumps/drainers by default.
But with binlogctl, we can specifiy
-show-offline-nodesto include offline pumps/drainers in the output.Check List
Tests
Code changes
Side effects
Related changes
Release note