binlogctl: Only show offline nodes when explicitly told so #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-integration-tests |
d4858c2 to
bece556
Compare
|
/run-all-tests |
|
Good Job! LGTM |
|
@WangXiangUSTC Could you show me the document that I need to update. |
|
/run-all-tests |
|
@suzaku we can merge this pr now and update doc later, just make sure doc is updated before release |
|
/run-all-tests |
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Oct 22, 2019
This was referenced Oct 22, 2019
|
@WangXiangUSTC Document updated. |
july2993
pushed a commit
that referenced
this pull request
Nov 1, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 25, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 25, 2019
This was referenced Nov 25, 2019
suzaku
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some users complain that pump/drainer nodes that have been turn off still appears in the list.
What is changed and how it works?
Hide
offlinenodes by default, only show them when-show-offline-nodesis set.Check List
Tests
I set a drainer to
offlineand then check withbinlogctl drainers.Code changes
Side effects
Related changes