Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: update mydumper backup docs #318

Merged
merged 4 commits into from
May 28, 2020
Merged

en: update mydumper backup docs #318

merged 4 commits into from
May 28, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Update CRD backup docs with mydumper.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added needs-cherry-pick-1.1 translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. labels May 26, 2020
@ran-huang ran-huang requested review from onlymellb and TomShawn May 26, 2020 15:37
@ran-huang ran-huang added the v1.1 This PR/issue applies to TiDB Operator v1.1. label May 26, 2020
TomShawn
TomShawn reviewed May 27, 2020
View reviewed changes
en/backup-to-gcs.md Outdated Show resolved Hide resolved
en/backup-to-gcs.md Outdated Show resolved Hide resolved
en/backup-to-s3.md Outdated Show resolved Hide resolved
en/backup-to-s3.md Outdated Show resolved Hide resolved
en/backup-to-s3.md Outdated Show resolved Hide resolved
ran-huang and others added 2 commits May 27, 2020 19:53
@ran-huang @TomShawn
Apply suggestions from code review
e7d4e3b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang @TomShawn
Apply suggestions from code review
6832f3e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
onlymellb
onlymellb approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang requested a review from TomShawn May 28, 2020 03:00
TomShawn
TomShawn approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 90b8a5d into pingcap:master May 28, 2020
@ran-huang ran-huang deleted the mydumper-backup branch May 28, 2020 03:26
@ran-huang
Copy link
Contributor Author

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-tidb-operator that referenced this pull request May 28, 2020
@ran-huang @sre-bot
cherry pick pingcap#318 to release-1.1
8389631 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request May 28, 2020
Merged
3 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

cherry pick to release-1.1 in PR #336

ran-huang added a commit that referenced this pull request May 28, 2020
@sre-bot @ran-huang
cherry pick #318 to release-1.1 (#336)
e8808a7 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn TomShawn self-requested a review May 31, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlymellb onlymellb onlymellb approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. v1.1 This PR/issue applies to TiDB Operator v1.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @TomShawn @sre-bot @onlymellb