-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: update mydumper backup docs #273
Conversation
Please fix the CI failure and then involve a tech reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry pick to release-1.1 in PR #283 |
@@ -128,6 +139,21 @@ GCS 支持以下几种 bucket ACL 策略: | |||
* `.spec.from.port`:待备份 TiDB 集群的访问端口。 | |||
* `.spec.from.user`:待备份 TiDB 集群的访问用户。 | |||
* `.spec.from.tidbSecretName`:待备份 TiDB 集群所需凭证的 secret。 | |||
* `.spec.gcs.bucket`:存储数据的 bucket 名字。 | |||
* `.spec.gcs.prefix`:这个字段可以省略,如果设置了这个字段,则会使用这个字段来拼接在远端存储的存储路径 `s3://${.spec.s3.bucket}/${.spec.s3.prefix}/backupName`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onlymellb s3://${.spec.s3.bucket}/${.spec.s3.prefix}/backupName
里并没有出现 .spec.gcs.prefix
这个字段哦,是不是写错了呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #327
What is changed, added or deleted? (Required)
Update CRD backup docs with mydumper.
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/tidb-operator#2435
pingcap/tidb-operator#2407