Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to set lambda memory increase webhook memory #3778

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Conversation

npalm
Copy link
Member

@npalm npalm commented Feb 21, 2024

  • Configurable memory for lambda
  • Webhook had no explicit memoery set, default is 128. Now set to 256 after running some benchmarking.

Tested

  • Deefault example
  • Multi runner example

@npalm npalm requested a review from koendelaat February 21, 2024 09:35
@npalm
Copy link
Member Author

npalm commented Feb 21, 2024

For now added more varialbes. Would be time to start some stratetic refactoring on the varialbes. And make a choice to keep simple variables vs objects.

modules/ami-housekeeper/variables.tf Outdated Show resolved Hide resolved
@npalm npalm merged commit 40bceb6 into main Feb 27, 2024
1 check passed
@npalm npalm deleted the npalm/webhook branch February 27, 2024 15:12
npalm pushed a commit that referenced this pull request Feb 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.8.0](v5.7.1...v5.8.0)
(2024-02-27)


### Features

* Add option to set lambda memory increase webhook memory
([#3778](#3778))
([40bceb6](40bceb6))
* migrate webhook runner configuration to SSM
([#3728](#3728))
([32492e3](32492e3))


### Bug Fixes

* **lambda:** bump the aws group in /lambdas with 6 updates
([#3772](#3772))
([3549bc1](3549bc1))
* **lambda:** bump the aws group in /lambdas with 6 updates
([#3783](#3783))
([b850e85](b850e85))
* **lambda:** bump the octokit group in /lambdas with 2 updates
([#3773](#3773))
([de9985a](de9985a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants