feat: migrate webhook runner configuration to SSM #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-aws-github-runner into nav/chore/use-ssm
|
Hey guys, any idea when this is going to be merged? |
There were few comments on this PR. Addressed and tested them today. Hopefully we should be able to merge this week. |
npalm
reviewed
Feb 8, 2024
…-aws-github-runner into nav/chore/use-ssm
npalm
reviewed
Feb 16, 2024
npalm
reviewed
Feb 16, 2024
npalm
reviewed
Feb 16, 2024
npalm
reviewed
Feb 16, 2024
npalm
reviewed
Feb 16, 2024
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
npalm
reviewed
Feb 23, 2024
npalm
approved these changes
Feb 26, 2024
npalm
pushed a commit
that referenced
this pull request
Feb 27, 2024
🤖 I have created a release *beep* *boop* --- ## [5.8.0](v5.7.1...v5.8.0) (2024-02-27) ### Features * Add option to set lambda memory increase webhook memory ([#3778](#3778)) ([40bceb6](40bceb6)) * migrate webhook runner configuration to SSM ([#3728](#3728)) ([32492e3](32492e3)) ### Bug Fixes * **lambda:** bump the aws group in /lambdas with 6 updates ([#3772](#3772)) ([3549bc1](3549bc1)) * **lambda:** bump the aws group in /lambdas with 6 updates ([#3783](#3783)) ([b850e85](b850e85)) * **lambda:** bump the octokit group in /lambdas with 2 updates ([#3773](#3773)) ([de9985a](de9985a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the confugration for the webhook from environment variables to SSM to avoid the maximum size of environment variables is reached.
Implementation
The webhook will read the configuration from SSM as json string. As long the lambda is hot the configuration is cached to speed-up the lambda time. In cases of configuration changes Lambda resources will be re-created by Terraform to ensure no cached values are used.
fix: #3594