Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Post-Processor Params to match new aikido interface #43

Merged
merged 7 commits into from
Aug 27, 2020
Merged

Update Post-Processor Params to match new aikido interface #43

merged 7 commits into from
Aug 27, 2020

Conversation

egordon
Copy link
Collaborator

@egordon egordon commented Aug 21, 2020 •
edited
Loading

Updates libada to be compatible with personalrobotics/aikido#581

Required for personalrobotics/ada_demos#45

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Add unit test(s) for this change

@egordon egordon requested review from brianhou and sniyaz August 21, 2020 19:31
@egordon egordon mentioned this pull request Aug 21, 2020
Merged
2 tasks
sniyaz
sniyaz suggested changes Aug 22, 2020
View reviewed changes
Copy link

@sniyaz sniyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome start! Requested a few updates, LMK if you have questions 😄

@egordon egordon requested a review from sniyaz August 25, 2020 23:25
sniyaz
sniyaz suggested changes Aug 26, 2020
View reviewed changes
Copy link

@sniyaz sniyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! There are just a few nits and small changes, and after that we should be good to go!

@egordon egordon requested a review from sniyaz August 26, 2020 04:14
sniyaz
sniyaz suggested changes Aug 26, 2020
View reviewed changes
Copy link

@sniyaz sniyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more change! Thanks again for doing this 😄

@egordon egordon requested a review from sniyaz August 26, 2020 23:07
sniyaz
sniyaz suggested changes Aug 27, 2020
View reviewed changes
Copy link

@sniyaz sniyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last nits! Then I think we're really and truly done with this 😄

@egordon egordon requested a review from sniyaz August 27, 2020 05:42
sniyaz
sniyaz approved these changes Aug 27, 2020
View reviewed changes
Copy link

@sniyaz sniyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@egordon egordon merged commit c7ef4c6 into master Aug 27, 2020
@egordon egordon deleted the egordon/fix_pp branch August 27, 2020 15:47
@egordon egordon restored the egordon/fix_pp branch August 27, 2020 16:13
egordon added a commit that referenced this pull request Aug 27, 2020
@egordon
Revert "Update Post-Processor Params to match new aikido interface (#43…
f0fb2fb 
…)"

This reverts commit c7ef4c6.
@egordon egordon mentioned this pull request Aug 27, 2020
Merged
egordon added a commit that referenced this pull request Aug 27, 2020
@egordon
Revert "Update Post-Processor Params to match new aikido interface (#43…
79c043b 
…)" (#44)

This reverts commit c7ef4c6.
Will re-merge commit with Aikido v0.4
@egordon egordon mentioned this pull request Aug 27, 2020
Merged
egordon added a commit that referenced this pull request Aug 31, 2020
@egordon
Redo Commit #43 (#45)
9e0e014 
* Removed old PP interface

* Added explicit instantiation for Parabolic Smoother

* Fixed comments, ran make format

* Addressed nits

* Last nit, moved function to -impl header

* Final make format

* Fixed final nits, fixed clang-format version to match aikido
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniyaz sniyaz sniyaz approved these changes

@brianhou brianhou Awaiting requested review from brianhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egordon @sniyaz