Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old post-processor code. #581

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Delete old post-processor code. #581

merged 3 commits into from
Aug 27, 2020

Conversation

sniyaz
Copy link

@sniyaz sniyaz commented Aug 14, 2020

Now that we've merged #579 and all upstream PRs, it's time to delete the old PP functionality before we had these nice new methods. Specifically, we're throwing out smoothPath, retimePath, retimePathWithKunz, and the old version of getTrajectoryPostProcessor that was hardcoded to return a ParabolicSmoother.

This will break lots of things upstream, but we'll handle those separately.


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@sniyaz sniyaz requested review from brianhou and egordon August 14, 2020 07:30
@sniyaz sniyaz added this to the Aikido 0.4.0 milestone Aug 14, 2020
@sniyaz
Copy link
Author

sniyaz commented Aug 14, 2020

@brianhou @egordon One open question right now for y'all: I went ahead and deleted the methods from ConcreteManipulator as well. Do we want to "pass through" the new PP methods (postProcessPath) in this class as well? Or is a simple deletion fine?

@sniyaz
Copy link
Author

sniyaz commented Aug 20, 2020

@brianhou I just sent out the libherb and herb3_demos PRs. Doesn't look like we ever used those methods in ConcreteManipulator anyway, and everything works.

If this looks fine, can we merge this soon?

@brianhou
Copy link
Contributor

Thanks for making these changes and propagating them downstream! Super excited to delete code 😄

I'll merge once Travis is happy and then release 0.4.0.

@brianhou brianhou merged commit 90a6e0f into master Aug 27, 2020
@brianhou brianhou deleted the sniyaz_delete_pp branch August 27, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants