Auto recover #80
Merged
Auto recover #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauer
reviewed
Aug 30, 2021
| IG.eState := ValidLo; //LO | ||
| ELSIF rV > 9.6 AND rV<= 9.9 THEN | ||
| ELSIF rV > 9.6 AND rV<= 9.9 AND (IG.xHV_SW) THEN | ||
| IG.eState := ValidHi; //HIGH | ||
| ELSIF rV < 0.18 THEN // |
There was a problem hiding this comment.
Probably a dumb question as I'm drive-by reviewing for a project I have nothing to do with, but should this include: AND Ig.xHV_SW like the others?
(If so, it might be a bit more readable to do a top-level IF xHV_SW THEN (check voltages) ELSE set_off_state)
There was a problem hiding this comment.
is it missing the range rv< 0.6 and rv>0.22? which should be valid or valid low?
There was a problem hiding this comment.
Should these values be local constants? Avoiding hardcoded values?
…and the GCC. The timer is default but can be set from the user program. AutoOn pv is available through epics to switch this function off. The Autorecover is set to always run unless a value has been written to that persistent variable. Still to be tested.
jyin999
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the FIX to GCC State change