Skip to content

Commit

Permalink
FIX: PIP xError bit for widget (#37)
Browse files Browse the repository at this point in the history
* DEV: Issue#20, Issue#22

Issue#20 : Ion Pumps use own pressure reading after turning on, also added a method for AutoOn. user program to invoke the method.

Issue#22, Update MKS 909 Hot Cathode POU with logging and all other upgrades.

* DEV: PIP AutoOn is availabe through pragma

* DEV: Gauge event severity and message changes

* DEV: PIP logger and VGC pmps

* DEV: Added Gagues 972,909

ENH: PTM MagDriveDigital has status updates
DEV: Serial_IO Methodes added to pumps with serial interface

* DEV: Unit Tests, Agilent Analog Signals. FIX: EBARA PTM Analaog Signals

* ENH: Comments

* FIX: PIP Pressure is not calculated when device is off

* Issues #11, #14,#21,#25,#27,#32

* Issue #17

* ENH: MKS 500 logger, Ebara dry pymp and ebara turbo

* FIX: Pragma

* ENH: Change the valve moving timout to 30s

* DEV: VGC new position State, Diode interlock ok function, Ebara max backing pressure

* ENH: xLog bool to switch off logger for noisy gauges
FIX: PTM_Ebara Current speed calculations

* DEV: Don't use hard-coded values

* BUG: move MKS317's ValidLo low limit to .15V

* STY: order range limits

* FIX: MKS317's ValidLo limit issue #36

* ENH: PIP xError

Co-authored-by: ghalym <ghalym@users.noreply.github.com>
Co-authored-by: n-wbrown <n-wbrown@users.noreply.github.com>
  • Loading branch information
3 people authored Jun 17, 2020
1 parent 9140c45 commit edaf43f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
8 changes: 7 additions & 1 deletion L2SIVacuum/DUTs/Pumps/ST_PIP.TcDUT
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ STRUCT
'}
xILKOk : BOOL;
{attribute 'pytmc' := '
pv: ERROR;
field: ZNAM FALSE ;
field: ONAM TRUE ;
io: i;
'}
xError : BOOL;
{attribute 'pytmc' := '
pv: AT_VAC_SP;
Expand Down
9 changes: 7 additions & 2 deletions L2SIVacuum/POUs/Functions/Pumps/FB_PIP_Gamma.TcPOU
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ timer(IN:= NOT stPump.q_xHVEna_DO, PT:= T#1s);
// TAW Experimental ion pump timeout
tPumpStartTimeout(IN:=(NOT stPump.i_xHV_DI AND stPump.q_xHVEna_DO));
tTimeOutAction(CLK:=tPumpStartTimeout.Q);
IF tTimeOutAction.Q THEN fbLogger(sMsg:='Pump time out.', eSevr:=TcEventSeverity.Critical); END_IF
IF tTimeOutAction.Q THEN fbLogger(sMsg:='Pump time out.', eSevr:=TcEventSeverity.Critical); END_IF
Expand Down Expand Up @@ -209,6 +209,8 @@ q_IG.sPath := This^.stPump.sPath;
<Action Name="IO" Id="{a9e5b5c0-3557-4ce9-a1b9-765648e955e7}">
<Implementation>
<ST><![CDATA[stPump.sIlkDeviceName := This^.i_stGauge.sPath;
stPump.xError := (stPump.eState = pumpFAULT);
(*inputs*)
stPump.i_iPRESS:= i_iPRESS;
stPump.i_xHV_DI:= i_xSP_DI;
Expand Down Expand Up @@ -263,7 +265,10 @@ this^.stPump.xHVEna_SW := run;]]></ST>
<LineId Id="1" Count="0" />
</LineIds>
<LineIds Name="FB_PIP_Gamma.IO">
<LineId Id="2" Count="4" />
<LineId Id="2" Count="0" />
<LineId Id="7" Count="0" />
<LineId Id="9" Count="0" />
<LineId Id="3" Count="3" />
<LineId Id="1" Count="0" />
</LineIds>
<LineIds Name="FB_PIP_Gamma.M_AutoOn">
Expand Down

0 comments on commit edaf43f

Please sign in to comment.