Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to RSQlite causes warnings #316

Closed
eliotmcintire opened this issue Jun 22, 2017 · 3 comments
Closed

Update to RSQlite causes warnings #316

eliotmcintire opened this issue Jun 22, 2017 · 3 comments
Assignees
@pbiecek
Labels
needs fast fix ready

Comments

@eliotmcintire
Copy link
Contributor

In saveToLocalRepo, createLocalRepo and likely others: many new warnings appearing, which appear to have come with RSQLite 2.0 which is now on CRAN.

a <- 1
repo <- tempdir()
archivist::createLocalRepo(repo)
archivist::saveToLocalRepo(a, repoDir = repo)

Warning messages:
1: In rsqlite_fetch(res@ptr, n = n) :
  Don't need to call dbFetch() for statements, only for queries
@pbiecek
Copy link
Owner

pbiecek commented Jun 23, 2017

thanks,
will check this along with #313

@pbiecek pbiecek self-assigned this Jun 23, 2017
pbiecek added a commit that referenced this issue Jun 23, 2017
@pbiecek
candidate fix for #316
4723418
@pbiecek
Copy link
Owner

pbiecek commented Jun 23, 2017

fixed with 3a0dff4

@eliotmcintire eliotmcintire mentioned this issue Jun 23, 2017
Closed
@pbiecek pbiecek added the ready label Jun 23, 2017
@MarcinKosinski
Copy link
Collaborator

Thanks for the report and fast fix : )

@pbiecek pbiecek closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbiecek pbiecek

Labels
needs fast fix ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eliotmcintire @pbiecek @MarcinKosinski