Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache warnings: Don't need to call dbFetch() for statements, only for queries #5

Closed
achubaty opened this issue Jun 22, 2017 · 2 comments
Closed

cache warnings: Don't need to call dbFetch() for statements, only for queries #5

achubaty opened this issue Jun 22, 2017 · 2 comments
Assignees
@eliotmcintire

Comments

@achubaty
Copy link
Collaborator

running testthat::test("~/GitHub/reproducible", "cache) generates a bajillion warnings:

Don't need to call dbFetch() for statements, only for queries

This is likely new with the release of the latest RSQLite package, and cropping up in archivist, as I don't see any calls we make to dbFetch(). @eliotmcintire can you please confirm and file bug with archivist as needed?

I will temporarily add suppressWarnings to the tests.
achubaty added a commit that referenced this issue Jun 22, 2017
@achubaty
TEMPORARY: suppress warnings in cache tests (#5)
af0cf0f 
@eliotmcintire we can revert this once the issue is dealt with in `archivist`
@eliotmcintire
Copy link
Contributor

Contacted archivist folks and they have fixed it. It will appear in CRAN eventually. pbiecek/archivist#316

@achubaty
Copy link
Collaborator Author

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliotmcintire eliotmcintire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eliotmcintire @achubaty