PAYARA-3824 Use KeyID from JWT header to find public key in JSON Web Key Set #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
jGauravGupta
approved these changes
Mar 5, 2019
|
LGTM, Need to test with MP TCK Runner. |
|
Jenkins test MicroProfile |
1 similar comment
|
Jenkins test MicroProfile |
arjantijms
approved these changes
Mar 6, 2019
|
@MeroRai |
|
Pass the MircoProfile TCK on the Payara Server. Although the TCK Runner will need to be updated for this PR to pass the test. I believe @jGauravGupta already did it but it has been revert back. |
|
Fixes #3795 |
|
Need to make sure both repos are updated at the same time. |
arjantijms
approved these changes
May 3, 2019
|
Jenkins test please |
|
jenkins test please |
This was referenced Jun 11, 2019
AlanRoth
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Tested locally and passed MPTCKs with TEST-198's changes (#4054 and payara/MicroProfile-TCK-Runners#44)
|
jenkins test please |
1 similar comment
|
jenkins test please |
I apologise, it was due to trying to resolve the conflicts using GitHub, which didn't save properly.
|
jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will use the KeyID
kidheader field (if present) from the JSON web token to find the matching public key in a JSON Web Key Set (JWKS) array. If there is no KeyID, then the first key entry will be used just like before.Following changes:
JwtTokenParser.javaso that I can access the JWT header without having to parse theSignedJWTtwice.keyIDdown to thecreatePublicKeyFromJWKSmethod in order to be able to find the matching JWK.