Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-198 Refactor JsonWebToken API in MP TCK Runner JWT Auth #39

Closed
wants to merge 1 commit into from
Closed

TEST-198 Refactor JsonWebToken API in MP TCK Runner JWT Auth #39

wants to merge 1 commit into from

Conversation

Pandrex247
Copy link
Member

Reverts #32
Requires payara/Payara#3799

Matt's comment from the original PR:

I'm not able to get this compiling against the linked PR, and this will also break the TCK runner suite for all old versions of Payara. I would suggest instead making use of the new maven regex profile activator to work around this.

@Pandrex247 Pandrex247 mentioned this pull request May 3, 2019
Merged
Pandrex247
Pandrex247 commented May 20, 2019
View reviewed changes
Copy link
Member Author

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt says that this code should flatly just be removed from the TCK and moved into Payara

@Pandrex247 Pandrex247 changed the title QA-198 Refactor JsonWebToken API in MP TCK Runner JWT Auth TEST-198 Refactor JsonWebToken API in MP TCK Runner JWT Auth Jun 10, 2019
@Pandrex247 Pandrex247 closed this Jul 4, 2019
@MarkWareham MarkWareham deleted the revert-32-revert-29-QA-198 branch May 22, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdudits pdudits pdudits approved these changes

@MarkWareham MarkWareham MarkWareham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandrex247 @pdudits @MarkWareham