Use name from CacheDefaults when injecting JCache (PAYARA-1106) #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
jenkins test please |
1 similar comment
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
All tests have passed |
gregrluck
approved these changes
Oct 9, 2016
There was a problem hiding this comment.
In the example application we have ScheduleDAO. @CacheDefaults is already being declared at the class level. i.e.
@ApplicationScoped
@CacheDefaults(cacheName = "schedule")
public class ScheduleDAO {
...
}
So this change means that we don't need to keep using the cacheName on individual annotations which is why @CacheDefaults was added to the spec in the first place.
smillidge
approved these changes
Oct 11, 2016
lprimak
pushed a commit
to flowlogix/Payara
that referenced
this pull request
Jul 5, 2017
Use name from CacheDefaults when injecting JCache (PAYARA-1106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124
Disclaimer: I don't really understand CDI lifecycle. I assume the producer method is called for each injection point.
Example usage (depends also on #1125)