Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Use javax.cache.annotation.CacheDefaults when injecting JCache #1124

Closed
jerrinot opened this issue Oct 6, 2016 · 4 comments
Closed

Proposal: Use javax.cache.annotation.CacheDefaults when injecting JCache #1124

jerrinot opened this issue Oct 6, 2016 · 4 comments
Milestone
Payara 4.1.1.164

Comments

@jerrinot
Copy link
Contributor

jerrinot commented Oct 6, 2016 •
edited
Loading

Payara uses CacheDefaults for cache resolution in the CDI interceptor as the spec mandates.

I believe it would make a lot of sense to use CacheDefaults as a cache resolution strategy when injecting JCache via @Inject.

Currently it does use name of a declaring class as a cache name. There is also the @NamedCache but that creates a dependency on Payara-specific code.
@jerrinot jerrinot changed the title IDEA: Use javax.cache.annotation.CacheDefaults for resolve JCache IDEA: Use javax.cache.annotation.CacheDefaults to resolve JCache name Oct 6, 2016
@jerrinot jerrinot changed the title IDEA: Use javax.cache.annotation.CacheDefaults to resolve JCache name IDEA: Use javax.cache.annotation.CacheDefaults when injecting JCache Oct 6, 2016
@jerrinot jerrinot changed the title IDEA: Use javax.cache.annotation.CacheDefaults when injecting JCache Proposal: Use javax.cache.annotation.CacheDefaults when injecting JCache Oct 6, 2016
@smillidge
Copy link
Contributor

Do you fancy making a PR to demonstrate?

@jerrinot
Copy link
Contributor Author

jerrinot commented Oct 6, 2016

I'll have a look at it.

The main issue I can foresee is a potential clash with the official Java EE - JCache integration. If the EG decided to not use the @CacheDefaults as a default name for caches injected via @Inject.

jerrinot added a commit to jerrinot/microprofile-conference that referenced this issue Oct 6, 2016
@jerrinot
Use default producer of JCache
d98b33a 
Depends on:
payara/Payara#1125
and
payara/Payara#1124
jerrinot added a commit to jerrinot/Payara that referenced this issue Oct 6, 2016
@jerrinot
Use name from CacheDefaults when injecting JCache
a9997fb 
Fixes payara#1124
jerrinot added a commit to jerrinot/microprofile-conference that referenced this issue Oct 6, 2016
@jerrinot
Use default producer of JCache
53a0859 
Depends on:
payara/Payara#1125
and
payara/Payara#1124
@jerrinot jerrinot mentioned this issue Oct 6, 2016
Merged
@gregrluck
Copy link

Lets cross that bridge when we get to it.

@OndroMih OndroMih added this to the Payara 4.1.1.164 milestone Nov 21, 2016
@Quix0r
Copy link

Quix0r commented Jan 28, 2019

So there is currently no other way to @Inject JCache than with Payara's @NamedCache? I would like to write my WAR project independent (I may call it portable) rather than bounded to a (vendor-)specific container and maybe major/minor version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 4.1.1.164
Development

No branches or pull requests
5 participants
@jerrinot @gregrluck @Quix0r @smillidge @OndroMih