addition of typescript files

[Layla-P]

Description

A definition type file has been created for patternfly.js

Changes

All new files

attn:
@bleathem

[bleathem]

This is great, thanks for the contribution @Layla-P! The typings are a good fit for this repo, as they will then be available for all consuming repos.

However the typescript api code introduced is not a good fit, as it doesn't reflect the programming model currently used in this repo.

Could you please remove the APIs and include only the typescript typings in this PR?

[Layla-P]

Hey @bleathem I have removed the files as requested. Are you happy with the typings files I have included? Or would you just like the patternfly one?

[bleathem]

Thanks @Layla-P. That's an interesting question, let's see what our community has to say.

@dgutride @dlabrecq @priley86 thoughts on the ts typing contribution from @Layla-P?

[dlabrecq]

I looked through the typescript definitions and there is a lot here. The definitions in patternfly.d.ts look like something we could pull into Patternfly because it's based on our scripts. I'm not sure about the definitions for jQuery, C3, D3, Datatables, and Bootstrap?

[Layla-P]

@dlabrecq I have written several typescript api's which make use of the type definitions such as a charting api. However, Brian asked me not to include them as he thought them not to be generic enough.
If the definitions aren't of use to you, that's no issue what so ever, I just thought I would share them and save someone the bother I've writing them as I have.
I have also written documentation on using the api's.

[dlabrecq]

Can you please share the documentation? That would be very helpful. Thanks!

[Layla-P]

@dlabrecq I have emailed you on your redhat email.

[bleathem]

Thanks again for the contribution @Layla-P. I discussed this PR with @dlabrecq and @jeff-phillips-18. While we feel the typings overall would be very useful for someone building there application with patternfly, the non-pattternfly typings would be better suited for a library like https://github.com/DefinitelyTyped/DefinitelyTyped.

The patternfly typing is however something that makes sense for use to host. Would you mind updating this PR to include only the patternfly typings file?

[bleathem]

I added a commit to this PR removing the non-jquery typings. I will next send an e-mail to patternfly-list to kickstart a discussion around whether or not the community would find the inclusion of this typings file to be a valuable addition to patternfly.

[Layla-P]

Hey Brian, Sorry I didnt get back to you. As you know I can't do this at work as we dont have fit and personally it's been a tough couple of weeks. I'd still like to contribute but not sure what. Kind regards, Layla

…

On 2 Aug 2017 22:58, "Brian Leathem" ***@***.***> wrote: I added a commit to this PR removing the non-jquery typings. I will next send an e-mail to patternfly-list to kickstart a discussion around whether or not the community would find the inclusion of this typings file to be a valuable addition to patternfly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <patternfly/patternfly#686 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/API6JnQxjk16Onqpr_vm_VpMpW9CBAzoks5sUPEZgaJpZM4Oebg2> .

[dgutride]

Replaced by #1043 - closing this PR - thanks for kicking off this conversation.