Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Add TypeScript definitions #1043

Merged
merged 1 commit into from
May 22, 2018

Conversation

dmiller9911
Copy link
Contributor

fix #1040

Description

Added TypeScript definitions for patternfly-settings.

Changes

Write a list of changes the PR introduces

  • patternfly-settings-* now have a corresponding patternfly-settings-*.d.ts file

Link to rawgit and/or image

N/A

PR checklist (if relevant)

N/A

  • Cross browser: works in IE9
  • Cross browser: works in IE10
  • Cross browser: works in IE11
  • Cross browser: works in Edge
  • Cross browser: works in Chrome
  • Cross browser: works in Firefox
  • Cross browser: works in Safari
  • Cross browser: works in Opera
  • Responsive: works in extra small, small, medium and large view ports.
  • Preview the PR: An image or a URL for designer to preview this PR is provided.

dgutride
dgutride previously approved these changes May 10, 2018
@dgutride
Copy link
Member

this looks good to me @jeff-phillips-18 - any more comments or are we good to go in?

@jeff-phillips-18
Copy link
Member

@dmiller9911 can you rebase please?

@jeff-phillips-18 jeff-phillips-18 merged commit 0295d87 into patternfly:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide color typedefs for typescript support
3 participants