Release v1.1.0 #88
Merged
Release v1.1.0 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code does not work with PastasProject
Update examples.rst
- name is now name of directory - path is location in which directory w name will be created/read
- allow passing kind to stresses plot as list or as str - allow axes to be iterable in _timeseries plot
- switch order of conn and name args, conn is now first and required, name is optional. - add check and deprecationwarning if order is not correct - improve docstrings - improve get_model_timeseries_names for different pastas versions
add test meta with name (#78)
- actually test stresses plot - add cumulative hist - only test bgmap for pas pstores - add test modelstat - add test ctx_providers
This was
linked to
issues
Mar 20, 2023
This was referenced Mar 20, 2023
martinvonk
reviewed
Mar 20, 2023
| @@ -1165,7 +1173,7 @@ def stresslinks( | |||
| markersize=10, | |||
| ) | |||
| ] | |||
| for kind in skind: | |||
| for kind in kinds: | |||
| (c,) = np.where(skind == kind) | |||
There was a problem hiding this comment.
np.where(kinds == kind)?
martinvonk
approved these changes
Mar 20, 2023
martinvonk
approved these changes
Mar 20, 2023
| @@ -1165,7 +1173,7 @@ def stresslinks( | |||
| markersize=10, | |||
| ) | |||
| ] | |||
| for kind in skind: | |||
| for kind in kinds: | |||
| (c,) = np.where(skind == kind) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with #85 and #87.
Warning, this new version does introduce two breaking changes:
pst.PastaStore(name, connector)topst.PastaStore(connector, name=name)with the name becoming optional.pst.PasConnectorthenameargument is now used to specify the directory name in which the database will be stored. Thepathargument defines the location of that directory. This is also a breaking change and will require users to modify theirPasConnectorfrompst.PasConnector("unused_name", path="./pastas_db")topst.PasConnector("pastas_db", path="."). This is more in line with the other Connectors.Some minor improvements to testing, coverage and documentation are also included.