Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stored name not showing up in stresses dataframe #87

Closed
dbrakenhoff opened this issue Mar 20, 2023 · 1 comment · Fixed by #88
Closed

stored name not showing up in stresses dataframe #87

dbrakenhoff opened this issue Mar 20, 2023 · 1 comment · Fixed by #88

Comments

@dbrakenhoff
Copy link
Member

When adding a stress with a metadata dictionary containing 'name' as a key:

pstore.add_stress(s, "my_name", kind="prec", metadata={"name": "not_what_i_intendend"})

The resulting pstore.stresses DataFrame uses the metadata name, and not the name passed when adding the stress as the index:

                                  kind
name                   
not_what_i_intended               prec

I should be seeing my_name there, regardless of the metadata dictionary.

dbrakenhoff added a commit that referenced this issue Mar 20, 2023
- use stored names as index, always
- disregard stored name in metadata
@dbrakenhoff dbrakenhoff linked a pull request Mar 20, 2023 that will close this issue
@dbrakenhoff
Copy link
Member Author

Fixed in #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant