Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boxed variant comparisons #542

Merged
merged 2 commits into from
Feb 3, 2025

Add boxed variant comparisons

68f01d4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add boxed variant comparisons #542

Add boxed variant comparisons
68f01d4
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Feb 3, 2025 in 0s

clippy

13 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 13
Note 0
Help 0

Versions

  • rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • cargo 1.84.1 (66221abde 2024-11-19)
  • clippy 0.1.84 (e71f9a9a98 2025-01-27)

Annotations

Check warning on line 23 in partiql-conformance-tests/src/bin/generate_comparison_report.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5
   |
23 | /// regressed behavior)
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
23 | ///   regressed behavior)
   |     ++

Check warning on line 353 in partiql-logical-planner/src/typer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
   --> partiql-logical-planner/src/typer.rs:353:21
    |
353 |                     _ => {
    |                     ^ no value can reach this
    |
note: multiple earlier patterns match some of the same values
   --> partiql-logical-planner/src/typer.rs:353:21
    |
341 |                     Lit::Null | Lit::Missing => self.bld.new_undefined(),
    |                     ------------------------ matches some of the same values
342 |                     Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => {
    |                     ------------------------------------------------------------ matches some of the same values
...
345 |                     Lit::Decimal(_) => type_decimal!(self.bld),
    |                     --------------- matches some of the same values
346 |                     Lit::Double(_) => type_float64!(self.bld),
    |                     -------------- matches some of the same values
...
353 |                     _ => {
    |                     ^ ...and 6 other patterns collectively make this unreachable
    = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 11 in extension/partiql-extension-ion/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `Bag` is never constructed

warning: variant `Bag` is never constructed
  --> extension/partiql-extension-ion/src/util.rs:11:5
   |
8  | pub enum PartiqlValueTarget<T> {
   |          ------------------ variant in this enum
...
11 |     Bag(Vec<T>),
   |     ^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 449 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`

warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:449:5
    |
449 |     pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:521:1
    |
521 | enum BoxedIonStreamType {
    | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 434 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5
    |
434 |     pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1
    |
96  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^

Check warning on line 434 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`

warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5
    |
434 |     pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1
    |
528 | enum BoxedIonValue {
    | ^^^^^^^^^^^^^^^^^^

Check warning on line 428 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5
    |
428 |     pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1
    |
96  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^

Check warning on line 428 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`

warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5
    |
428 |     pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1
    |
528 | enum BoxedIonValue {
    | ^^^^^^^^^^^^^^^^^^
    = note: `#[warn(private_bounds)]` on by default

Check warning on line 112 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:112:1
    |
112 | pub type IonContextPtr = Rc<RefCell<IonContext>>;
    | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1
    |
96  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^
    = note: `#[warn(private_interfaces)]` on by default

Check warning on line 133 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `deserializer`

warning: unused variable: `deserializer`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:133:23
    |
133 |     fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error>
    |                       ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`

Check warning on line 123 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `serializer`

warning: unused variable: `serializer`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:123:28
    |
123 |     fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error>
    |                            ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 5 in extension/partiql-extension-ion/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Deserialize` and `Serialize`

warning: unused imports: `Deserialize` and `Serialize`
 --> extension/partiql-extension-ion/src/lib.rs:5:13
  |
5 | use serde::{Deserialize, Serialize};
  |             ^^^^^^^^^^^  ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 123 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
   --> partiql-value/src/variant.rs:123:28
    |
123 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>);
    |            -----------     ^^^^^^^^^^^^^^^^^^^^^^^^^
    |            |
    |            field in this struct
    |
    = help: consider removing this field
    = note: `#[warn(dead_code)]` on by default