Skip to content

Add boxed variant comparisons #3117

Add boxed variant comparisons

Add boxed variant comparisons #3117

Triggered via push February 3, 2025 19:51
Status Failure
Total duration 6m 58s
Artifacts

coverage.yml

on: push
Matrix: Build and Test
Fit to window
Zoom out
Zoom in

Annotations

1 error and 26 warnings
Build and Test (ubuntu-20.04)
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
doc list item without indentation: partiql-conformance-tests/src/bin/generate_comparison_report.rs#L23
warning: doc list item without indentation --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5 | 23 | /// regressed behavior) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 23 | /// regressed behavior) | ++
unreachable pattern: partiql-logical-planner/src/typer.rs#L353
warning: unreachable pattern --> partiql-logical-planner/src/typer.rs:353:21 | 353 | _ => { | ^ no value can reach this | note: multiple earlier patterns match some of the same values --> partiql-logical-planner/src/typer.rs:353:21 | 341 | Lit::Null | Lit::Missing => self.bld.new_undefined(), | ------------------------ matches some of the same values 342 | Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => { | ------------------------------------------------------------ matches some of the same values ... 345 | Lit::Decimal(_) => type_decimal!(self.bld), | --------------- matches some of the same values 346 | Lit::Double(_) => type_float64!(self.bld), | -------------- matches some of the same values ... 353 | _ => { | ^ ...and 6 other patterns collectively make this unreachable = note: `#[warn(unreachable_patterns)]` on by default
variant `Bag` is never constructed: extension/partiql-extension-ion/src/util.rs#L11
warning: variant `Bag` is never constructed --> extension/partiql-extension-ion/src/util.rs:11:5 | 8 | pub enum PartiqlValueTarget<T> { | ------------------ variant in this enum ... 11 | Bag(Vec<T>), | ^^^ | = note: `#[warn(dead_code)]` on by default
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L449
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:449:5 | 449 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:521:1 | 521 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L434
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5 | 434 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L434
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5 | 434 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1 | 528 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L428
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5 | 428 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L428
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5 | 428 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1 | 528 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_bounds)]` on by default
type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`: extension/partiql-extension-ion/src/boxed_ion.rs#L112
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr` --> extension/partiql-extension-ion/src/boxed_ion.rs:112:1 | 112 | pub type IonContextPtr = Rc<RefCell<IonContext>>; | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L133
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:133:23 | 133 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L123
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:123:28 | 123 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `0` is never read: partiql-value/src/variant.rs#L123
warning: field `0` is never read --> partiql-value/src/variant.rs:123:28 | 123 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>); | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this struct | = help: consider removing this field = note: `#[warn(dead_code)]` on by default
doc list item without indentation: partiql-conformance-tests/src/bin/generate_comparison_report.rs#L23
warning: doc list item without indentation --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5 | 23 | /// regressed behavior) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 23 | /// regressed behavior) | ++
unreachable pattern: partiql-logical-planner/src/typer.rs#L353
warning: unreachable pattern --> partiql-logical-planner/src/typer.rs:353:21 | 353 | _ => { | ^ no value can reach this | note: multiple earlier patterns match some of the same values --> partiql-logical-planner/src/typer.rs:353:21 | 341 | Lit::Null | Lit::Missing => self.bld.new_undefined(), | ------------------------ matches some of the same values 342 | Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => { | ------------------------------------------------------------ matches some of the same values ... 345 | Lit::Decimal(_) => type_decimal!(self.bld), | --------------- matches some of the same values 346 | Lit::Double(_) => type_float64!(self.bld), | -------------- matches some of the same values ... 353 | _ => { | ^ ...and 6 other patterns collectively make this unreachable = note: `#[warn(unreachable_patterns)]` on by default
variant `Bag` is never constructed: extension/partiql-extension-ion/src/util.rs#L11
warning: variant `Bag` is never constructed --> extension/partiql-extension-ion/src/util.rs:11:5 | 8 | pub enum PartiqlValueTarget<T> { | ------------------ variant in this enum ... 11 | Bag(Vec<T>), | ^^^ | = note: `#[warn(dead_code)]` on by default
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L449
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:449:5 | 449 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:521:1 | 521 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L434
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5 | 434 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L434
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:434:5 | 434 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1 | 528 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L428
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5 | 428 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L428
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:428:5 | 428 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:528:1 | 528 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_bounds)]` on by default
type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`: extension/partiql-extension-ion/src/boxed_ion.rs#L112
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr` --> extension/partiql-extension-ion/src/boxed_ion.rs:112:1 | 112 | pub type IonContextPtr = Rc<RefCell<IonContext>>; | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:96:1 | 96 | struct IonContext { | ^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L133
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:133:23 | 133 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L123
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:123:28 | 123 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `0` is never read: partiql-value/src/variant.rs#L123
warning: field `0` is never read --> partiql-value/src/variant.rs:123:28 | 123 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>); | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this struct | = help: consider removing this field = note: `#[warn(dead_code)]` on by default